Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about findDOMNode in console #56

Closed
raatmarien opened this issue Mar 28, 2020 · 4 comments
Closed

Warning about findDOMNode in console #56

raatmarien opened this issue Mar 28, 2020 · 4 comments
Labels
bug Something isn't working frontend wontfix This will not be worked on
Projects

Comments

@raatmarien
Copy link
Owner

    in div (at CardComponent.tsx:104)
    in DraggableCore (created by Draggable)
    in Draggable (at CardComponent.tsx:91)
    in div (at CardComponent.tsx:90)
    in CardComponent (at TableComponent.tsx:23)
    in div (at TableComponent.tsx:17)
    in TableComponent (at App.tsx:67)
    in div (at App.tsx:65)
    in App (at src/index.tsx:9)
    in StrictMode (at src/index.tsx:8)```
@raatmarien raatmarien created this issue from a note in Development (To do) Mar 28, 2020
@raatmarien raatmarien added bug Something isn't working frontend labels Mar 28, 2020
@FredrikAugust
Copy link

Hello! Saw this issue, and thought I'd share some insight as I've encountered this before.

Long story short, there's nothing you can do to fix this except either stop using react-draggable, or forking react-draggable and reworking it to not use findDomNode.

The reason you're getting this warning is because you're using the new React.StrictMode, which is warning you about the deprecation of findDomNode.

There is an issue opened up at react-draggable which addresses this, but no action has been taken yet (not even a dev response).

The best thing you can do is probably wait for them to fix this, as for now, it appears it still works, it just gives you a warning during development.

@raatmarien
Copy link
Owner Author

Thanks for your detailed explanation Frederik! I think you are right and waiting is the best solution. Maybe there is a possibility to suppress or hide this warning, but I'd have no idea how.

@FredrikAugust
Copy link

No problem!

As for suppressing the error; I think the only way of doing this is by not using strict mode, but then you lose the benefits of strict mode, so it's a matter of priority. If it's any consolidation, the warning isn't printed in production :)

@raatmarien
Copy link
Owner Author

Ah, that it isn't shown in production is a lot better already, good to know. I will close the issue then :)

@raatmarien raatmarien added the wontfix This will not be worked on label Apr 3, 2020
Development automation moved this from To do to Done Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend wontfix This will not be worked on
Projects
Development
  
Done
Development

No branches or pull requests

2 participants