-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cell.Value is corrupted with furigana #25
Comments
こんいちは Thank you for the report. So, have I understood the issue correct: I will have a look into the formatting in the shared string table. This (inline formatting) is on top of my backlog as ToDo. Thank you in advance for clarification. |
Yes, Excel does not display the furigana part. I have been using files containing Japanese for over 10 years and have never needed furigana. Therefore, my conclusion is that there is no problem with lost furigana. For a program to preserve the furigana, you generally need a different object model than a single value. |
OK, thank you. When I implemented the shared string table, I decided to remove all paragraphs and to keep all enclosed text, to preserve any content. However, since Furigana is only a Kanji transcription, it's presence breaks the sentence / word structure ,as you already stated. Let me look for the best solution to preserve formatted text and to remove transcriptions. I have analyze the rPH (and possible others) tag a little bit. Maybe it can always be ignored or there will be an import option, if there are use cases, where rPH content is meaningful. Please give me some time to do this. Currently, I am working on a big refactoring (dev branch) and I have to adapt any change on several braches and projects. どうもありがとうございました。 |
I have some good news. |
Hello Could you provide me with some additional samples, where Kanji characters are transcribed by Furigana? I would suggest something like that:
If you could provide me an Excel file with these (or similar) use cases, I could test my patch properly. Currently, I cannot predict the right tag structure. Thank you very much in advance. |
Thank you for your quick response. We will gladly provide sample data. Please wait a moment. |
Sample data attached. |
ただいま
Please let me know if something is not working as expected. |
I will close this issue for now. If you try out the fix and find something that is not as you would expecting, please do not hesitate to re-open or file a new issue. |
Thanks for fixing it. |
An xlsx file created with the Japanese version of Excel 2019 contains an annotation called Furigana.
When that xlsx file is read in the NanoXLSX file, the furigana is mixed in the Cell.Value, resulting in an incorrect value.
Cell.Value is expected to ignore the furigana.
Steps to reproduce the problem:
The text was updated successfully, but these errors were encountered: