Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a logging interface #81

Closed
lukebakken opened this issue May 1, 2022 · 0 comments · Fixed by #84
Closed

Provide a logging interface #81

lukebakken opened this issue May 1, 2022 · 0 comments · Fixed by #84
Assignees
@lukebakken
Milestone
1.4.0

Comments

@lukebakken
Copy link
Contributor

Reference: redis/go-redis#1279

There are several places in PR #78 where a panic has been inserted if an error is returned from low-level functions. Panicking is not appropriate, but neither is disregarding the error. These errors should be logged at the error or warning level.
@lukebakken lukebakken self-assigned this May 1, 2022
@lukebakken lukebakken added this to the 1.3.5 milestone May 1, 2022
This was referenced May 1, 2022
Closed
Merged
@lukebakken lukebakken mentioned this issue May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Add logging rabbitmq/amqp091-go
1 participant
@lukebakken