Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some releases are missing certain RPMs #92

Closed
der-eismann opened this issue Sep 14, 2020 · 7 comments
Closed

Some releases are missing certain RPMs #92

der-eismann opened this issue Sep 14, 2020 · 7 comments

Comments

@der-eismann
Copy link

Hey everyone,

I just noticed that there are quite a few packages missing on the releases page. Some examples:

I downloaded them from packagecloud for now, so the RPMs are there, they just didn't get pushed to GitHub. It would be great if someone could fix the pipeline.

@michaelklishin
Copy link
Member

I will produce and tag 23.0.4 now to see if this can be a timing issue in the pipeline. If so, it will have to wait until the pipeline that produces these packages is 100% automated (including detecting upstream tags). I updated the releases mentioned manually.

@michaelklishin
Copy link
Member

The packages uploaded to GitHub as part of a release are taken from Bintray. If some of them are not available, looks like they won't get included:

  - name: tag-package-release-22
    serial: true
    plan:
      - in_parallel:
        - get: ci
          tags: [erlang-elixir]
        - get: centos-7-image
          tags: [erlang-elixir]
        - get: erlang-rpm-src-22
          tags: [erlang-elixir]
          passed:
            - build-erlang-rpm-22-el6
            - build-erlang-rpm-22-el7
            - build-erlang-rpm-22-el8
        - get: erlang-rpm-package-22-el8-on-bintray
          tags: [erlang-elixir]
          passed:
            - build-erlang-rpm-22-el8
        - get: erlang-rpm-package-22-el7-on-bintray
          tags: [erlang-elixir]
          passed:
            - build-erlang-rpm-22-el7
        - get: erlang-rpm-package-22-el6-on-bintray
          tags: [erlang-elixir]
          passed:
            - build-erlang-rpm-22-el6
      - task: format-tag
        tags: [erlang-elixir]
        image: centos-7-image
        file: ci/erlang-rpm/tasks/format-tag.yaml
        input_mapping:
          erlang-rpm-src: erlang-rpm-src-22
      - put: erlang-rpm-src-22
        tags: [erlang-elixir]
        params:
          repository: erlang-rpm-src-22
          tag: tag/tag
          only_tag: true
      - put: erlang-rpm-package-22-on-github
        tags: [erlang-elixir]
        params:
          name: github-release/name
          tag: tag/tag
          body: github-release/body
          globs:
          # A package version on Bintray contains all RPMs (for all CentOS versions)
           - 'erlang-rpm-package-22-el7-on-bintray/erlang/*/el/*/x86_64/erlang-*.rpm'

Concourse's in_parallel step is supposed to fail of any of the steps do. So currently the question is why this does not happen.

@michaelklishin michaelklishin changed the title Missing RPMs on release page Some releases are missing certain RPMs Sep 14, 2020
@michaelklishin
Copy link
Member

According to build logs, the EL8 package is not present in the directory during the upload put step:

18:11:48
creating release 23.0.4
18:11:49
uploading /tmp/build/put/erlang-rpm-package-23-el7-on-bintray/erlang/23/el/6/x86_64/erlang-23.0.4-1.el6.x86_64.rpm
18:11:50
uploading /tmp/build/put/erlang-rpm-package-23-el7-on-bintray/erlang/23/el/7/x86_64/erlang-23.0.4-1.el7.x86_64.rpm

and this is reproducible, which is good news.

@der-eismann
Copy link
Author

EL8 packages are present for all newer tags, so I guess this is fixed?

@michaelklishin
Copy link
Member

No, I uploaded them manually. Only two out of three RPMs are attached to GitHub releases by Concourse. All three are published to Bintray.

@michaelklishin
Copy link
Member

Curiously 23.1.2 does have all three RPMs published by Concourse. It could be a regression in a Concourse resource which has been addressed but it's just a guess at this point.
I will reopen this if we see a relapse.

@michaelklishin
Copy link
Member

Another set of changes that lead me to believe this has been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants