Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid URI encoding with URLEncoder.encode() #97

Closed
dumbbell opened this issue Feb 2, 2017 · 0 comments
Closed

Invalid URI encoding with URLEncoder.encode() #97

dumbbell opened this issue Feb 2, 2017 · 0 comments
Assignees

Comments

@dumbbell
Copy link
Member

dumbbell commented Feb 2, 2017

The client uses URLEncoder.encode() to escape path segments in the created URLs. Unfortunately, this module produces invalid path segments: it transforms spaces to +. This is fine for query string, but not path segments.

Newer versions of Cowboy, which have a stricter URL parsing, leave the + characters alone. So when a user of this HTTP client wants to create eg. a vhost with a space in it, he ends up with a vhost with a +.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants