Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When -y 0 (no consumers) and -p (predeclared entities) are used, server-named queues should not be declared #25

Closed
michaelklishin opened this issue Jun 27, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@michaelklishin
Copy link
Member

Currently when -y 0 and -p are combined to test a consumer application (the idea is to only use PerfTest for publishing), a server-named queue is declared and while it is auto-delete, it never has any consumers => sticks around.

This is confusing and annoying.

Reported by @liwang-pivotal.

Perhaps a more sensible behavior would be to not "configure" (pre-declare, bind) any queues when --predeclared is passed and we have no consumers. I can't currently see any scenarios where the behavior we have right now would be desired.

@michaelklishin michaelklishin self-assigned this Jun 27, 2017
@michaelklishin michaelklishin added this to the 1.3.0 milestone Jun 27, 2017
@michaelklishin
Copy link
Member Author

@acogoluegnes I'm happy to revert this if you see any downsides, a customer @liwang-pivotal is working with was pretty annoyed by this so we decided to rush it a bit since it only affects a rare combination of CLI switches :)

@acogoluegnes
Copy link
Collaborator

@michaelklishin Makes perfect sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants