Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checkbashisms to our testsuite #323

Open
dumbbell opened this issue Sep 24, 2015 · 3 comments
Open

Add checkbashisms to our testsuite #323

dumbbell opened this issue Sep 24, 2015 · 3 comments
Assignees
@dumbbell
Labels
effort-low enhancement

Comments

@dumbbell
Copy link
Member

We must use checkbashisms on all shell scripts in our testsuite so we detect problems before the release...
@dumbbell dumbbell self-assigned this Sep 24, 2015
@dumbbell dumbbell added this to the 3.5.6 milestone Sep 24, 2015
@michaelklishin michaelklishin removed this from the 3.5.6 milestone Oct 4, 2015
@michaelklishin
Copy link
Member

Should probably go into 3.5.7 because 3.5.6 will have to go out early, see #324.

@michaelklishin michaelklishin added this to the 3.6.0 milestone Oct 6, 2015
@michaelklishin michaelklishin removed this from the 3.6.0 milestone Nov 23, 2015
@michaelklishin
Copy link
Member

@dumbbell do you think our new shell test suites and ShellCheck address this or more tests are necessary?

@dumbbell
Copy link
Member Author

dumbbell commented Jan 3, 2019

Are you talking about test-rabbitmq-server-scripts? It doesn't run checkbashisms(1) currently.

Our package testsuites might not covered everything either.

To me this issue is not addressed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dumbbell dumbbell

Labels
effort-low enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelklishin @dumbbell