Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel can crash on send_drained #7119

Closed
mkuratczyk opened this issue Jan 31, 2023 · 0 comments · Fixed by #7141
Closed

Channel can crash on send_drained #7119

mkuratczyk opened this issue Jan 31, 2023 · 0 comments · Fixed by #7141
Assignees
Labels
Milestone

Comments

@mkuratczyk
Copy link
Contributor

Classic queues send lists but QQs and Streams don't. The action type is underspecified here:

-type action() ::
%% indicate to the queue type module that a message has been delivered
%% fully to the queue
{settled, Success :: boolean(), [msg_tag()]} |
{deliver, rabbit_types:ctag(), boolean(), [rabbit_amqqueue:qmsg()]} |
{block | unblock, QueueName :: term()}.

This may lead to a channel crash:

{function_clause,[{rabbit_channel,'-handle_queue_actions/2-inlined-0-',
    [{send_drained,[{<<99,116,97,103,45,0,0,0,0>>,999}]},

Note: different queue types and protocols need to be considered (AMQP1.0, MQTT, CQ, QQ, Stream...).

Originally reported on the mailing list: https://groups.google.com/g/rabbitmq-users/c/z9ykigcY2cI/m/WpBjsYDSAAAJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants