Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix partition calculation in hash routing strategy #199

Closed
acogoluegnes opened this issue Sep 27, 2022 · 0 comments
Closed

Fix partition calculation in hash routing strategy #199

acogoluegnes opened this issue Sep 27, 2022 · 0 comments
Assignees
@acogoluegnes
Labels
bug Something isn't working
Milestone
0.8.0

Comments

@acogoluegnes
Copy link
Contributor

Use Integer.remainderUnsigned(int, int) instead of % as the murmur 3 hash is an unsigned 32-bit.

Note this can change the partition order for the same key before releases of the client library, this is considered OK as this is fixed before RabbitMQ 3.11 GA is announced.
@acogoluegnes acogoluegnes self-assigned this Sep 27, 2022
@acogoluegnes acogoluegnes added the bug Something isn't working label Sep 27, 2022
@acogoluegnes acogoluegnes added this to the 0.8.0 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acogoluegnes acogoluegnes

Labels
bug Something isn't working
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
1 participant
@acogoluegnes