Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing Node.js port based on async/await #207

Open
cocodrino opened this issue Mar 14, 2019 · 1 comment
Open

Contributing Node.js port based on async/await #207

cocodrino opened this issue Mar 14, 2019 · 1 comment

Comments

@cocodrino
Copy link

Hi, this is a bit related to other issue that I opened sometime ago (sorry I can't found the issue) where I wanted to contribute code in nodejs using async await.

I think it would be great if there was the possibility within the same sample page to switch between the current code, using callbacks, the promises implementation and using async await, all through a navs system like https://getbootstrap.com/docs/4.3/components/navs/

I found that the code exists using promises and my implementation with async await is here

https://github.com/cocodrino/rabbitmq-tutorials-async-await

I would like to know if this is possible and how I could collaborate

Thank you.

@michaelklishin
Copy link
Member

This repository contains executable code only, one directory per implementation regardless of the client. Simply add a new directory with your version with a README that contains an overview and some hints as to how to run them.

The site is at rabbitmq/rabbitmq-website. We are interested in having one recommended API used in the tutorials, not three. A link to alternative ones can be added, of course. Async/await makes most sense but we'd need to discuss the switch with the team first.

Thank you.

@michaelklishin michaelklishin changed the title include tabs (navs) for toggle between nodejs examples with callback,promise and async await implementation Contributing Node.js port based on async/await Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants