-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-platfrom file watching support #12
Comments
Is that the only blocking issue for OSX? Hard to say I guess. Should be an easy fix, that's the library I'm actually already using, so this would be a small change. Will look into that. Thanks for reporting. |
Yeah from what I can tell, it should be the only issue. The other crates either explicitly mention macOS support or they are platform-independent. |
To make a long story short - "inotify" (but also epoll) are Linux only "techno-logies", so using Linux only stuff will limit usability of the project on other platforms :) |
Yeah, this also prevents it from working on BSD systems. Ironically it works nicely on Windows (with WSL)... |
Ok, so I did take a look and it was even easier to fix than I thought, just needed to replace InotifyWatcher with RecommendedWatcher at three points. There are likely to be issues with how those notifications are handled/issued at the OS level due to differences between systems and I will take a look into that later, but it should at least compile and run now. EDIT: From what I can see the only issues that might arise affect all platforms since I was lazy, so if it runs this is more or less solved. |
Yeah, please do! Jumping wanna try it on macOS. |
I already did, it's in the master branch. :) Just waiting for someone to report success before I close the issue. |
From the looks of it, this is caused by the metadata-fetching, maybe related to the thread-pool somehow. Will investigate further, thanks for testing. Closing this issue since this crash has nothing to do with file watching. |
See : #17 Please test if it works. |
Cool, it builds, but crashes immediately on startup. Will open a new ticket. Ah, wait, I see you did something in #17 but the version from crates.io still crashes. Was there a release with fix yet? |
It seemed to be fine from the reports I got, but apparently not. :( Please open a new issue and include a stack trace if you can. It's probably rather an issue with a file it tries to load, rather than something that has to do with macOS. Since I added the panic-handler it should print it fine when it crashes. You could try to open it in different directories and see if it starts up. |
Hi! |
On macOS, compilation currently fails with the following error message:
That's because
inotifywatch
is Linux-specific.I recommend https://github.com/passcod/notify for cross-platform filesystem notifications.
The text was updated successfully, but these errors were encountered: