Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated build API for 1.4.0 #107

Merged
merged 6 commits into from Jun 2, 2020
Merged

Updated build API for 1.4.0 #107

merged 6 commits into from Jun 2, 2020

Conversation

rabitt
Copy link
Collaborator

@rabitt rabitt commented May 23, 2020

Implements option B from issue #106

  • build_file takes array or file inputs and generates file outputs, returning a boolean
  • build_array takes array or file inputs and returns np.ndarray outputs

build_file is an alias for build, and I moved the documentation to point people towards using build_file, while keeping build fully functional.

I also did a little cleanup of how set_input_format and set_output_format work - rather than storing the list of format arguments to be passed to sox, it stores a dictionary which is parsed when running build/build_array, which cleans up the build functions substantially.

@rabitt
Copy link
Collaborator Author

rabitt commented May 23, 2020

cc @pseeth @nicolamontecchio @psobot @carlthome @hadware @lostanlen @justinsalamon

@coveralls
Copy link

coveralls commented May 23, 2020

Coverage Status

Coverage increased (+0.4%) to 99.104% when pulling 5830789 on build-api into 0591cb8 on master.

@pseeth
Copy link
Contributor

pseeth commented May 23, 2020

Awesome work! Seems coverage is falling a tiny bit but other than that, lgtm!

@pseeth
Copy link
Contributor

pseeth commented May 28, 2020

Any chance of a merge into master and a pip release if this is ready?

@rabitt rabitt merged commit 6fbd589 into master Jun 2, 2020
@rabitt rabitt mentioned this pull request Jun 2, 2020
@rabitt
Copy link
Collaborator Author

rabitt commented Jun 2, 2020

@pseeth this is up on pypi! pip install pysox --pre
give it a spin and let me know if you run into any issues

@carlthome
Copy link

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants