Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using a named logger so callers can configure log levels. #62

Merged
merged 3 commits into from Nov 15, 2017

Conversation

psobot
Copy link

@psobot psobot commented Nov 15, 2017

Closes #51. This is kind of hacky, but should work and should allow callers to configure pysox logging via logging.getLogger('sox') on the global logging object.

@coveralls
Copy link

coveralls commented Nov 15, 2017

Coverage Status

Coverage increased (+0.004%) to 98.751% when pulling 3047f19 on psobot:psobot/named-logger into 49dfb16 on rabitt:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 98.751% when pulling 74a3b51 on psobot:psobot/named-logger into 49dfb16 on rabitt:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 98.751% when pulling 74a3b51 on psobot:psobot/named-logger into 49dfb16 on rabitt:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 98.751% when pulling 74a3b51 on psobot:psobot/named-logger into 49dfb16 on rabitt:master.

@coveralls
Copy link

coveralls commented Nov 15, 2017

Coverage Status

Coverage increased (+0.004%) to 98.751% when pulling 726b5c6 on psobot:psobot/named-logger into 49dfb16 on rabitt:master.

@rabitt
Copy link
Collaborator

rabitt commented Nov 15, 2017

👍 Thanks @psobot !

@rabitt rabitt merged commit 3ed47c9 into marl:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants