New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove grep dependency, parse help string in python #67
Conversation
@rabitt this is ready for CR and merge, just 6 lines. |
Looks good to me @justinsalamon , thanks for the PR. @mthaak can you confirm that this works on windows? |
Also @justinsalamon can you squash the commits into one? |
@rabitt did that (squashing) work? |
@justinsalamon no I still see 5 commits in the PR. Also waiting for @mthaak (or anyone with a windows machine) to confirm this PR fixes the problem on windows. |
@rabitt apparently you can setup the repo to have a "squash and merge" button instead of just a "merge" button - maybe the cleanest option (commits stay in branch, but squashed on master)? |
Thanks for this @justinsalamon , and thanks for reporting @mthaak. |
Calling grep breaks pysox (and subsequently) scaper on windows. This PR addresses this be removing the use of grep altogether and parsing the sox help string directly in python.
Addresses issue #66 in pysox, issue justinsalamon/scaper#25 in scaper