Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base call to SoX uses shell=True in subprocess call #79

Closed
rabitt opened this issue Jul 27, 2018 · 2 comments
Closed

Base call to SoX uses shell=True in subprocess call #79

rabitt opened this issue Jul 27, 2018 · 2 comments
Assignees
Labels

Comments

@rabitt
Copy link
Collaborator

rabitt commented Jul 27, 2018

Filenames with wildcards have always behaved inconsistently with pysox. Looking into this more closely, found that - the SoX command arguments being passed to the shell rather than to the binary directly.

Thanks @jongwook for finding the source!

@rabitt rabitt added the bug label Jul 27, 2018
@rabitt rabitt self-assigned this Jul 27, 2018
@rabitt rabitt changed the title Base call to SoX uses shell=True in subprocess call Base call to SoX uses shell=True in subprocess call Jul 27, 2018
@lostanlen
Copy link
Member

@rabitt
Copy link
Collaborator Author

rabitt commented Jul 27, 2018

@lostanlen unfortunately it's a change that creates cascading changes all over the library. Working on it now.

rabitt added a commit that referenced this issue Jul 27, 2018
@rabitt rabitt closed this as completed in e3c4be3 Jul 27, 2018
rabitt added a commit that referenced this issue Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants