Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT pysoundfile -> soundfile #162

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

lostanlen
Copy link
Member

Came up in conversation with @adinhodovic while reviewing #153. Quote from soundfile:

Breaking Changes
The soundfile module has evolved rapidly in the past. Most notably, we changed the import name from import pysoundfile to import soundfile in 0.7. In 0.6, we cleaned up many small inconsistencies, particularly in the the ordering and naming of function arguments and the removal of the indexing interface.

I believe this is urgent and should happen as part of the 1.4.2 bugfix release. I don't know if that implies a break of compatibility?

@hugovk your thoughts?

@coveralls
Copy link

Coverage Status

coverage: 98.823% (-0.03%) from 98.856%
when pulling 8cb0905 on pysoundfile-to-soundfile
into e99079a on master.

@hugovk
Copy link
Contributor

hugovk commented Jan 23, 2024

Sounds like a good idea, pysoundfile was last updated 5 years ago, and soundfile is being maintained.

The thing I'd watch out for is breaking changes, and it might be an idea to put that out in a corresponding major bump.

However, the coverage here is really high, so if you have confidence in the tests, you could do it in a non-major too. I'd still probably lean towards a minor over patch.

@lostanlen
Copy link
Member Author

@hugovk OK so this would be versioned as 1.5.0 (minor), not 1.4.2 (bugfix)? We probably should make a beta release for that, right?

@hugovk
Copy link
Contributor

hugovk commented Jan 23, 2024

Yep, 1.5.0. I think beta releases are a good idea in theory, but in my experience, very few people ever try them, so it's usually better to just release. Release early, release often! Automated releases really help.

@lostanlen lostanlen merged commit bdfef38 into master Jan 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants