Set only default level for the sox logger #65
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following example, I'd expect log messages from the example
logger
and only warnings or error messages from the sox logger.Although, the default level of the sox logger is set to
logging.WARNING
, I get the info messages anyway:In my opinion the log level should be set to the sox logger rather than to the console
StreamHandler
which gets overwritten by thelogger.basicConfig
anyway.Furthermore, I don't see the need of setting up a log handler here. This should be done by the user of the library.
However, I really appreciate the work, which has been put into this project. Thank you! :-)
Cheers,
Stefan