Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in generation of technique administration files #44

Closed
SanWieb opened this issue Mar 16, 2021 · 2 comments
Closed

Inconsistency in generation of technique administration files #44

SanWieb opened this issue Mar 16, 2021 · 2 comments
Assignees
Labels
invalid This doesn't seem right wontfix This will not be worked on

Comments

@SanWieb
Copy link

SanWieb commented Mar 16, 2021

Hi,

There is a small inconsistency at the generation of the technique administration files.

The command python dettect.py ds -fd sample-data/data-sources-endpoints.yaml -y will generate a administration file without a '-' before the applicable_to key. Like this:

  - technique_id: T1001.001
    technique_name: Junk Data
    detection:
      applicable_to:
      - all
      location:
      - ''
      comment: ''
      score_logbook:
      - date: 
        score: -1
        comment: ''

However in the example there is a '-' before applicable_to, the output of the DeTT&CT editor also contains the '-'.
A YAML exception (duplicated mapping key) occurs if you add another applicable_to block without '-'.

@marcusbakker marcusbakker self-assigned this Mar 17, 2021
@marcusbakker marcusbakker added wontfix This will not be worked on invalid This doesn't seem right labels Mar 17, 2021
@marcusbakker
Copy link
Contributor

Hi Sander,

Thanks for indicating. We will however not fix this issue for the following reasons:

  • Our advice would be to edit a technique administration file through the Editor and not directly by changing the YAML file's content. The reason being that it's pretty error-prone doing it in that way. There are of course exceptions, like replace specific values all at once in the YAML file or some automation you're using to make changes to the content.
  • The Editor and CLI will handle these kind of technique objects without any issue.
  • It's by design. Not having this in a list by default (using '-') does not make it an incompatible YAML file.

Regards,
Marcus

@SanWieb
Copy link
Author

SanWieb commented Mar 18, 2021

Hi Marcus,

Thanks for the quick response! I understand the consideration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants