-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drag and drop inside chromium broken when notion is running #19
Comments
I see that rearranging tabs is broken again in chromium too (I'm quite sure it has worked at some point) |
Interesting. what versions are you on? I'm on the https://github.com/raboof/notion/tree/xft branch of notion and version 50.0.2661.94-1~deb8u1 of chromium, and both rearranging tabs (within a chromium window) and the 'dragover' events appear to work fine. Dragging chromium tabs across windows/screens does cause some issues for me though. |
$ notion --version $ chromium --version (drag events is bugged here too) |
not sure which version I have
I will try to compile notion from source and report back... |
So I tried current
both exhibit the problem I described in first post. drag/drop of tabs in chrome is hard for me to test because I don't even know how it's supposed to work. dragging a tab results in a new chrome window being created. |
@raboof, I'm on chrome 51.0.2704.63 (64-bit) and |
Is there a way to turn off wm-supported drag & drop? I would really at least like drag & drop wo work inside a single chromium instance, don't really need cross-frame drag & drop. Why does it work in firefox and not in chrome? I don't even understand the issue. Maybe someone can enlighten me? |
It's getting stranger: I switched to firefox because drag & drop works in firefox. However now selecting options from certain select controls using the mouse doesn't work in firefox when notion is running. It works when I kill notion. example: http://ui-grid.info/docs/#/tutorial/103_filtering, scroll down and try to select a gender from the select control in the gender header of the table. I don't get it. How can notion even prevent that from functioning? |
That is really weird. It seems like the mouse coordinates used are offset from the real coordinates. eg. I select 'female' the result is 'male'. I select 'unknown', 'female' is selected. (the list is ' ', 'male', 'female', 'unknown', ...) When I try with fullscreen (no tabbar) it works as expected. It would be interesting to know if other "fringe" WMs are affected too (xmonad, i3, etc). It trigger associations to the java problems we are plagued with. |
I can confirm the firefox "cannot-select-option"-problem is alleviated by making firefox fullscreen (has to be on first screen, too) The original "dragover event missing in chrome"-problem is not alleviated by this. |
@olejorgenb wrote:
I tried both xmonad and i3, neither of them have any of the 2 problems |
I don't see any of those problems, I'll try to reproduce further without my ~/.notion later... |
fixes the chrome drag-and-drop and tab-rearrange-within-window problems here, but not the firefox dropdown problem. |
cool! can confirm net_client_list.lua fixes the chromium drag & drop issues (tabs and also dragover and other events). Can also confirm the firefox issue is not fixed by this. thank you guys a ton for your help. I'll close the bug and make a donation to 1EhUSroL4FWaM1qypYbXfBxUQv1zGDZ16H, which I assume is the donation address for notion. |
@molecular thanks! let's not close this bug just yet, I think this is reason enough to include net_client_list in the default configuration - we want to create a nice out-of-the-box experience :). Let's create another issue for the firefox dropdown problem? |
@raboof ok, I agree putting net_client_list into default config is a good idea, depending on what the possible side-effects are. EDIT: can someone with a better understanding of the firefox problem create an issue for it? I'm having a hard time even describing it correctly. |
I made an attempt: #20 |
I just filed a chromium bug report: https://bugs.chromium.org/p/chromium/issues/detail?id=617139, but that problem only occurs when notion is running.
The issue in chromium is, when one initiates a drag & drop on a web-page, something goes wrong and the expected "dragover" events do not happen. "dragstart" event does happen, but after that, it's silence.
Here's a jsfiddle that shows the issue: http://jsfiddle.net/G9mJw/20/
When you drag the red square over the dotted rectangle, the text above the rectangle should count dragover events. If notion is not running, this works, if notion is running, no dragover events are captured.
The text was updated successfully, but these errors were encountered: