Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale_sites = TRUE does not work #24

Closed
rabutler-usbr opened this issue Apr 7, 2020 · 0 comments
Closed

scale_sites = TRUE does not work #24

rabutler-usbr opened this issue Apr 7, 2020 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@rabutler-usbr
Copy link
Owner

flow_mat <- cbind(c(2000, 2001, 2002), c(1400, 1567, 1325))
# made up historical data to use as index years
ind_flow <- cbind(1901:1980, rnorm(80, mean = 1500, sd = 300))
# make up monthly flow for two sites
mon_flow <- cbind(
  rnorm(80 * 12, mean = 20, sd = 5),
  rnorm(80 * 12, mean = 120, sd = 45)
)
d1 <- knn_space_time_disagg(
  flow_mat, 
  ind_flow, 
  mon_flow, 
  start_month = 1, 
  scale_sites = TRUE,
  k_weights = knn_params(1, 1)
)

results in:

Sites 2
will be selected directly from the index years, i.e., not scaled.

It should scale all sites.

Need to add this as a test.

@rabutler-usbr rabutler-usbr added the bug Something isn't working label Apr 7, 2020
@rabutler-usbr rabutler-usbr added this to the v0.1.0 milestone Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant