Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse request method and parameters on HTTP 307 redirect. #138

Merged
merged 1 commit into from May 30, 2017

Conversation

nightscape
Copy link
Contributor

This is a minimal patch with test that fixes #119 by keeping the original request method when forwarding with a 307.

@soumyaray
Copy link

This PR really needed to respect status 307's intention. Any chance it will get merged in soon?

@perlun
Copy link
Contributor

perlun commented May 22, 2017

@nightscape and @soumyaray - sorry for the huge delay on this one. The project has been largely unmaintained for a long time, but things are now better.

Could you rebase this on top of current master? I think it's a good fix, we should include it in the next gem version. Ping @junaruga also so we remember to include it in the list of changes.

@nightscape
Copy link
Contributor Author

Ok, I just rebased. Let's see what Travis says.

@nightscape
Copy link
Contributor Author

Ok, Travis is happy with it. All good from my side!

Copy link
Contributor

@perlun perlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Merging. @junaruga - if you have a chance to update the history file, I'll appreciate it greatly.

@perlun perlun merged commit b276462 into rack:master May 30, 2017
@junaruga
Copy link
Contributor

junaruga commented May 30, 2017

@perlun Yes, I will update the history file. But it's not now.
I will do it as 1 pull-request before next version release seeing past commits on master branch.
It's hard to update history file one by one.

alex-damian-negru pushed a commit to alex-damian-negru/rack-test that referenced this pull request Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep original method when follow_redirect! a HTTP 307
4 participants