History.md #191
Merged
History.md #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
requested changes
Jul 7, 2017
History.md
Outdated
| * Feature/bulk pr for readme updates (Patrick Mulder #65, | ||
| Troels Knak-Nielsen #74, Jeff Casimir #76) | ||
| * Switches README format to markdown (Dennis Sivia #176) | ||
| * Converts History.txt to markdown (Dennis Sivia #179) |
There was a problem hiding this comment.
Minor detail: I think the grammar here could be consistent with the previous lines (Port to RSpec 3, Allow better testing of cookies)
So these should be:
- Switch README format to Markdown
- Convert History.txt to markdown
There was a problem hiding this comment.
Thanks for the review.
Updated as 1 more commit.
After finishing review, we can squash it.
perlun
approved these changes
Jul 7, 2017
Closed
alex-damian-negru
pushed a commit
to alex-damian-negru/rack-test
that referenced
this pull request
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
History.mdto latest master branch.You can see modified History here.
https://github.com/junaruga/rack-test/blob/feature/update-history/History.md