Contributing to Rack
Fork the Project
Fork the project on Github and check out your copy.
git clone https://github.com/contributor/rack.git cd rack git remote add upstream https://github.com/rack/rack.git
Create a Topic Branch
Make sure your fork is up-to-date and create a topic branch for your feature or bug fix.
git checkout master git pull upstream master git checkout -b my-feature-branch
Bundle Install and Quick Test
Ensure that you can build the project and run quick tests.
bundle install --without extra bundle exec rake test
Running All Tests
Install all dependencies.
Run all tests.
The test suite has no dependencies outside of the core Ruby installation and bacon.
Some tests will be skipped if a dependency is not found.
To run the test suite completely, you need:
To test Memcache sessions, you need memcached (will be run on port 11211) and dalli installed.
Try to write a test that reproduces the problem you're trying to fix or describes a feature that you want to build.
We definitely appreciate pull requests that highlight or reproduce a problem, even without a fix.
Implement your feature or bug fix.
Make sure that
bundle exec rake fulltest completes without errors.
Document any external behavior in the README.
Add a line to CHANGELOG.
Make sure git knows your name and email address:
git config --global user.name "Your Name" git config --global user.email "email@example.com"
Writing good commit logs is important. A commit log should describe what changed and why.
git add ... git commit
git push origin my-feature-branch
Make a Pull Request
Go to https://github.com/contributor/rack and select your feature branch. Click the 'Pull Request' button and fill out the form. Pull requests are usually reviewed within a few days.
If you've been working on a change for a while, rebase with upstream/master.
git fetch upstream git rebase upstream/master git push origin my-feature-branch -f
Make Required Changes
Amend your previous commit and force push the changes.
git commit --amend git push origin my-feature-branch -f
Check on Your Pull Request
Go back to your pull request after a few minutes and see whether it passed muster with Travis-CI. Everything should look green, otherwise fix issues and amend your commit as described above.
It's likely that your change will not be merged and that the nitpicky maintainers will ask you to do more, or fix seemingly benign problems. Hang on there!
Please do know that we really appreciate and value your time and work. We love you, really.