Skipping empty params inside query what lead to parsing error.

Example of these cookies would be: "foo=bar,;bar=foo" or ",foo=bar;,"
rack · Apr 12, 2012 · cb05a10 · sgrunberger · May 29, 2012 · cb05a10
1 parent 6496241
commit cb05a10
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/lib/rack/utils.rb b/lib/rack/utils.rb
@@ -67,6 +67,7 @@ def parse_query(qs, d = nil)
       params = KeySpaceConstrainedParams.new
 
       (qs || '').split(d ? /[#{d}] */n : DEFAULT_SEP).each do |p|
+        next if p.empty?
         k, v = p.split('=', 2).map { |x| unescape(x) }
         next unless k || v
 

diff --git a/test/spec_utils.rb b/test/spec_utils.rb
@@ -118,6 +118,8 @@ def kcodeu
     Rack::Utils.parse_query("&key&").should.equal "key" => nil
     Rack::Utils.parse_query(";key;", ";,").should.equal "key" => nil
     Rack::Utils.parse_query(",key,", ";,").should.equal "key" => nil
+    Rack::Utils.parse_query(";foo=bar,;", ";,").should.equal "foo" => "bar"
+    Rack::Utils.parse_query(",foo=bar;,", ";,").should.equal "foo" => "bar"
   end
 
   should "parse nested query strings correctly" do