No error if invalid status_code?

[Aryk]

Looking at Rack::Utils, I noticed:

    # Responses with HTTP status codes that should not have an entity body
    STATUS_WITH_NO_ENTITY_BODY = Set.new((100..199).to_a << 204 << 205 << 304)

    SYMBOL_TO_STATUS_CODE = Hash[*HTTP_STATUS_CODES.map { |code, message|
      [message.downcase.gsub(/\s|-|'/, '_').to_sym, code]
    }.flatten]

    def status_code(status)
      if status.is_a?(Symbol)
        SYMBOL_TO_STATUS_CODE[status] || 500
      else
        status.to_i
      end
    end
    module_function :status_code

Problem is

Rack::Utils.status_code(:not_foundd) # => 500
Rack::Utils.status_code(21345) # => 500

I propose to introduce a status_code! function that throws an error if it is invalid and does not just default to 500.

Would you guys accept a PR on that?

[nateberkopec]

See #1034

[rafaelfranca]

#1034 is merged now.