CommonLogger cannot handle non-Array responses.

[postmodern]

I noticed that in CommonLogger, it performs an implicit Array splat when receiving responses from the parent application:

      status, header, body = @app.call(env)

This will not properly set headers or body if the parent application returns Rack::Response or a Struct.new(:status, :headers, :body).

[postmodern]

This can be fixed by aliasing to_ary to finish.

[postmodern]

This is due to a change in Ruby 1.9.2. http://redmine.ruby-lang.org/issues/show/1393

[postmodern]

Patch: http://github.com/postmodern/rack/commit/9efef67634d55625cb8a7ddcd9e2b1059fca7e34

[raggi]

i've seen this and agree, i'll get to it when i have some time, there's no need to be rude in the channel. thank you for your patch, it is appreciated.

[postmodern]

Thanks for tracking this. I guess in the mean time I can extend Rack::Response and add the alias there.

[raggi]

Yeah, I'm sorry we don't have more time right now, and the last two releases have needed a bit of work :-/

[raggi]

pushing shortly.