Port to Moo and MooX::Types::MooseLike #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Email::Sender switched to Moo at v1.300000 2013-01-02
|
Why didn't use Type::Tiny here? Also please add versioned prerequisite on Moo. Otherwise great idea and thanks for your time! |
|
On 09/11/15 14:56, Stefan Hornburg (Racke) wrote:
Email::Sender uses MooX::Types::MooseLike so don't want to add a new dep.
Will do.
|
|
Ok that sounds reasonable. |
|
Dep on Moo now versioned along with dep on version of Email::Sender where switch to Moo was made. |
|
Excellent. |
racke
added a commit
that referenced
this pull request
Nov 9, 2015
Port to Moo and MooX::Types::MooseLike
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Email::Transport has been using Moo since the start of 2013 so about time we got this switched.