Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of some wildcard imports #125

Merged
merged 1 commit into from May 14, 2013
Merged

Get rid of some wildcard imports #125

merged 1 commit into from May 14, 2013

Conversation

ema
Copy link
Contributor

@ema ema commented Apr 26, 2013

  • The wildcard import in falcon/http_error.py seems unnecessary
  • Import specific exception in falcon/request.py
  • Import specific status codes in falcon/responders.py

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) when pulling 052eed4 on ema:master into 8ccea8d on racker:master.

@kgriffs
Copy link
Member

kgriffs commented Apr 29, 2013

This looks great. Can you update your commit message to follow AngularJS conventions per HACKING.md?

See also: https://github.com/racker/falcon/blob/master/HACKING.md

@kgriffs
Copy link
Member

kgriffs commented May 9, 2013

Style is fine. :)

Sent from Mailbox for iPhone

On Tue, May 7, 2013 at 8:34 AM, Emanuele Rocca notifications@github.com
wrote:

Sure. It's not clear to me if this change should fall in the 'feat' or 'style' category, though.

Reply to this email directly or view it on GitHub:
#125 (comment)

This patch removes an unused wildcard import in http_error. It also removes
wildcard imports in request and responders, replacing them with explicit ones.
@kgriffs kgriffs merged commit 415401b into falconry:master May 14, 2013
kingforaday added a commit to kingforaday/falcon that referenced this pull request Jan 21, 2019
doc: Add a warning to the Request.path docstring re url encoding falconry#125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants