Fix discovery module loading #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
chinmay-gupte
force-pushed
the
chinmay/fix_discovery_module_loading_for_query
branch
from
6cdea5c
to
4486142
Compare
chinmay-gupte
added a commit
that referenced
this pull request
Feb 19, 2015
…le_loading_for_query Fix discovery module loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were trying to create an object of
HttpMetricsIndexHandlerand "getting" the instance of discovery in it, even before actually loading it. This caused the instance to benullfailing the metrics_list call.This PR adds functionality to the discovery module loader, to try loading the discovery module, if
null