Timer sum double #442
Merged
Timer sum double #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the sample bundle
1. serializeV1 is only for testing and writes sum as long 2. Tests prove that written in any format, the serializer is able to deserialize them.
methods to take timerVersion parameter to reduce code duplication
| @@ -535,7 +556,7 @@ private static AbstractRollupStat getStatFromRollup(byte statType, BasicRollup b | |||
| public ByteBuffer toByteBuffer(Object o) { | |||
| try { | |||
| byte type = typeOf(o); | |||
| byte[] buf = new byte[sizeOf(o, type)]; | |||
| byte[] buf = new byte[sizeOf(o, type, VERSION_2_TIMER)]; | |||
There was a problem hiding this comment.
It seems a bit strange to pass in the timer version while serializing non-timer rollups like gauges, counters etc. What do you think about having two overloaded methods named sizeOf with one accepting just two arguments i.e (Object, Type) which will be used by all non-timer rollup types and then the other one with timerVersion as the third argument, which gets called by the timer serializer?
There was a problem hiding this comment.
This is much cleaner. I originally thought there was a problem doing it this way, but it seems much better. I'll push some changes shortly.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of:
#440
Chinmay asked for some changes, and Tilo asked me to do them while she is at Rax.io for the week.
The only part of this PR that still needs to be reviewed is this:
24ecd6e