George/multiplot simple number bug #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of integers and added a few more error log messages
in addition to rollups and to confirm that only rollups get returned for non string metrics
|
Just to be clear, the bug that occurs is that Multiplot queries use AstyanaxReader.getPointsFromColumns() which was returning integers for full res metrics, (instead of SimpleNumbers, which is what SinglePlot full res returns. That causes this method to break because it can't handle Integers: |
|
+1. Nice catch! |
GeorgeJahad
added a commit
that referenced
this pull request
Mar 19, 2015
…r_bug George/multiplot simple number bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of generating points with "new". This fixes
multiplot query because it causes it to return SimpleNumber's
instead of Integers.
to test Full resolution metrics and confirm that it is returning
SimpleNumbers instead of integers.
to make the code a bit more readable.