Delayed metrics reroll config #760
Conversation
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ## IN PROGRESS | |||
| * Upgraded datastax driver to 3.1.2 | |||
| * Added new configuration option DELAYED_METRICS_REROLL_GRANULARITY | |||
There was a problem hiding this comment.
YAY!!!!!
We probably need to document this (and the previous Rollup configs) more, but it doesn't have to be in the Release Notes. Maybe add something in the wiki later?
There was a problem hiding this comment.
Let's add it to the wiki as a part of this story. I think mentioning it in the release notes is good, so people know what versions its valid for.
There was a problem hiding this comment.
Once everything is merged to master, I plan on writing a wiki page just for delayed metrics explaining various configs and how to tweak them.
| * | ||
| * For example, a slot key of granularity | ||
| * {@link Granularity#MIN_1440 MIN_1440}, for destination granularity of | ||
| * {@link Granularity#MIN_60 MIN_60}, will have 6*4=24 children. |
There was a problem hiding this comment.
Curious, Is this a normal example? I mean, do we normally ask from 1 day (1440m) granularity to 1 hr (60m) granularity, skipping the 240m granularity?
Also, the term "children" is not as clear, but I realized it's probably been used in other places. At first I thought 1440m is a child of the 240m. I don't know if it's possible to change to "Finer" and "Coarser"
There was a problem hiding this comment.
There is getChildrenKeys above which would list children of all sublevels. This method uses that and only returns the level we are interested in. I just followed the terminology used there.
| public Collection<SlotKey> getChildrenKeys(Granularity destGranularity) { | ||
|
|
||
| if (!getGranularity().isCoarser(destGranularity)) { | ||
| throw new IllegalArgumentException("Current granularity must be coarser than the destination granularity"); |
There was a problem hiding this comment.
Can you print the 2 granularities involved in the Exception msg?
Introducing a new configuration, DELAYED_METRICS_REROLL_GRANULARITY, using which we control the granularity upto which we re-roll only the delayed metrics instead of entire slot.