remove enums #761
remove enums #761
Conversation
|
@usnavi @ChandraAddala @izrik @drenalin23 pls review |
|
Oh, btw, I need someone who knows about how Enums are implemented in blueflood-elasticsearch to scrutinize the code changes there. I have to admit, I'm shooting in the dark! 😬 |
| @@ -69,7 +69,7 @@ public void writeAllAstyanaxReadAllDatastax() throws IOException { | |||
|
|
|||
| Table<Locator, String, String> meta = HashBasedTable.create(); | |||
| meta.put( l0, CACHE_KEY, RollupType.GAUGE.toString() ); | |||
| meta.put( l1, CACHE_KEY, RollupType.ENUM.toString() ); | |||
| meta.put( l1, CACHE_KEY, RollupType.SET.toString() ); | |||
There was a problem hiding this comment.
Why are we adding this? I assume its a statsd type?
There was a problem hiding this comment.
We are not adding it. I'm just replacing ENUMs with SETs.
|
The only comment I have is, we havent removed column family definitions of column families corresponding to enums. |
| @@ -142,83 +133,16 @@ | |||
| //token paths matching query, which also have a next level. | |||
| tokenInfoBuilder.addTokenPathWithNextLevel(metricIndexData.getTokenPathsWithNextLevel()); | |||
|
|
|||
| Set<String> completeMetricsMatchingQueryPrevLevel = metricIndexData.getCompleteMetricNamesAtBaseLevel(); | |||
There was a problem hiding this comment.
Is this necessary for sub-metrics? any thoughts @caddala?
There was a problem hiding this comment.
We need to know if it is a complete metric name at base level to look for enums. If there are no enums we dont need it.
But I think we can adjust the regex expression a little bit, now that we dont need that information. We can create another story to look into this API after we cleanup enums.
Remove enums implementation and support