Dead code

[dkempe]

In common/math.rkt there are multiple instances of dead code that, were it live, would be unsafe.

In both vector-ormap and vector-andmap, the final case of the case-lambda clause (for cases with more than two input vectors) is never called. If they were, the vector reference would be referencing exactly outside of the bounds of the vector. Specifically, (vector-ref xs n) where (= n (vector-length xs)) is called thrice for each definition.

[stamourv]

I don't see the exact access you're referring to, but the ones on lines 174 and 176 (and their equivalents in vector-ormap) definitely look suspicious. Line 169 (mutatis mutandis) also looks odd. Why iterate to 2, instead of over all of vs.

If that code is indeed dead, would you be interested in submitting a pull request to get rid of it? A PR fixing it and adding tests for the currently-broken behavior works too. :)

[bennn]

6ca968b