Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false-positive when pystring contains '<...>' #69

Closed
Bertk opened this issue Nov 25, 2018 · 3 comments
Closed

false-positive when pystring contains '<...>' #69

Bertk opened this issue Nov 25, 2018 · 3 comments
Labels
Milestone

Comments

@Bertk
Copy link

Bertk commented Nov 25, 2018

The rule missing-data-table-column should ignore "pystrings (Doc Strings)" in a scenario (see screenshot, source file https://github.com/SonarOpenCommunity/sonar-cxx/blob/master/integration-tests/features/test_execution_statistics.feature)
fp

@racodond
Copy link
Owner

Hi @Bertk,

Thanks for your feedback!
Pystrings cannot be ignored because they can contain placeholders.

I'll try to remove those false positives by checking if they are preceded by the include keyword.

Tell me what you think.

Thank you

Have a good day!

David

@racodond racodond added the bug label Nov 27, 2018
@racodond racodond added this to the 1.8 milestone Nov 27, 2018
@Bertk
Copy link
Author

Bertk commented Nov 30, 2018

Hi David,

I am not sure whether adding a check for #include pre-processor directive is necessary.
This feature file is used for the C++ Community plugin tests and nobody else will do this.

Using escape sequences "\<", "\>" might be a workaround. If this is successful a hint in the issues to use escape sequence would be nice.

I will check this with a pull request tomorrow.

Best regards
Bert

https://github.com/cucumber/cucumber/blob/master/gherkin/docs/ast.pdf

@Bertk
Copy link
Author

Bertk commented Dec 1, 2018

Hi David,

I checked with this PR SonarOpenCommunity/sonar-cxx#1609 and the escape sequence did not break the test.

I am still not sure whether a Pystring can be used to define a symbolic name for values.

Regards
Bert

@Bertk Bertk closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants