You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
it seems that the makefiles include sudo usage explicitly for the purpose of running docker. i think we should not be embedding sudo usage into the makefile as it can be an unwelcome surprise.
we should move the sudo usage outside of the makefile, with some documentation about the possible need to run as root, as well as links to the docker documentation about configuring non-root usage.
after some discussions on slack about the appropriateness of having sudo in the makefile, i want to offer another possible solution.
we make a tools/docker.sh in the top level of the repo and have the makefile call the script with sudo privileges depending on the operation requested. this way, we will have the makefil enshrine the proper way to do things in a security conscious environment and have the scripts available for users who just want to run the docker commands.
it seems that the makefiles include sudo usage explicitly for the purpose of running docker. i think we should not be embedding sudo usage into the makefile as it can be an unwelcome surprise.
we should move the sudo usage outside of the makefile, with some documentation about the possible need to run as root, as well as links to the docker documentation about configuring non-root usage.
example docker config https://docs.docker.com/engine/installation/linux/rhel/#/create-a-docker-group
The text was updated successfully, but these errors were encountered: