Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sudo usage should be removed from makefile #5

Closed
elmiko opened this issue Jul 27, 2016 · 2 comments
Closed

sudo usage should be removed from makefile #5

elmiko opened this issue Jul 27, 2016 · 2 comments

Comments

@elmiko
Copy link
Contributor

elmiko commented Jul 27, 2016

it seems that the makefiles include sudo usage explicitly for the purpose of running docker. i think we should not be embedding sudo usage into the makefile as it can be an unwelcome surprise.

we should move the sudo usage outside of the makefile, with some documentation about the possible need to run as root, as well as links to the docker documentation about configuring non-root usage.

example docker config https://docs.docker.com/engine/installation/linux/rhel/#/create-a-docker-group

@elmiko
Copy link
Contributor Author

elmiko commented Sep 9, 2016

after some discussions on slack about the appropriateness of having sudo in the makefile, i want to offer another possible solution.

we make a tools/docker.sh in the top level of the repo and have the makefile call the script with sudo privileges depending on the operation requested. this way, we will have the makefil enshrine the proper way to do things in a security conscious environment and have the scripts available for users who just want to run the docker commands.

@elmiko elmiko mentioned this issue Mar 7, 2017
@tmckayus
Copy link
Collaborator

tmckayus commented Mar 1, 2018

There currently are no sudo commands in make files

@tmckayus tmckayus closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants