Has one bug #168
Closed
Has one bug #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a regression test for this issue too? |
|
@radar done |
jhawthorn
pushed a commit
to jhawthorn/paranoia
that referenced
this pull request
Jan 19, 2015
jhawthorn
pushed a commit
to jhawthorn/paranoia
that referenced
this pull request
Jan 19, 2015
|
This test case has been merged and is now passing. Thanks 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the model of has_one association of the paranoid model is not a paranoid then it throws error because of with_deleted called on the association.
Added a check of paranoid? before executing the query to restore has_one association.