Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodejs bindings should follow node callback conventions #132

Closed
dweinstein opened this issue Jul 22, 2016 · 2 comments
Closed

Nodejs bindings should follow node callback conventions #132

dweinstein opened this issue Jul 22, 2016 · 2 comments
Labels
enhancement nodejs
Milestone
1.0.0

Comments

@dweinstein
Copy link

dweinstein commented Jul 22, 2016 •
edited

@jpenalbae
Copy link
Collaborator

About the err, this was proposed back in the day, but wasn't done to avoid breaking the compatibility with old scripts.

About the second issue (async functions should actually be async), feel free to send a PR.

@radare radare added this to the 1.0.0 milestone Oct 4, 2016
@radare
Copy link
Collaborator

radare commented Oct 4, 2016

agree on that. we should fix this before 1.0 (5 weeks)

@radare radare closed this as completed in ea64a3d Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement nodejs
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@dweinstein @radare @jpenalbae