Add support for x86-32 gcc "mov r,[r*s+d];jmp r" jumptables #10271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please @rlaemmert review/fix the tests and add a test for your |
|
to write the test do the following: and then |
|
I'm going to try this tonight/tomorrow and provide feedback! That's definitely something I'm interested in :) |
|
I have rebased the PR, cc @rlaemmert |
|
do we have a testcase for this in r2r? |
Thanks @rlaemmert for providing test case - This PR also improves the analysis of MOV instructions on X86 - And extends output of 'ao' to show ireg, scale, ...
|
tired of watiing. i did the test that i described here and im fixing the tests. will hopefully merge today |
|
should be green now, cleaning up printfs. took me 11 minutes.. |
|
r2r test is here https://github.com/radare/radare2-regressions/pull/1353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @rlaemmert for providing test case