Make up lines even more beautiful

[jdz]

Use dashed line from the same Unicode block as other line drawing
characters. This ensures that they all are present in the same font,
are the same width and align perfectly.

Re-opening #11727 according to guidelines.

[jdz]

3/4 tests failed because r2r PR was (initially) not rebased on top of master.

[codecov-io]

Codecov Report

Merging #11770 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11770      +/-   ##
==========================================
+ Coverage   37.02%   37.03%   +<.01%     
==========================================
  Files         901      901              
  Lines      288124   288082      -42     
==========================================
- Hits       106692   106688       -4     
+ Misses     181432   181394      -38

Impacted Files	Coverage Δ
libr/core/disasm.c	73.46% <ø> (ø)	⬆️
libr/asm/p/asm_m68k_cs.c	71.01% <0%> (-0.82%)	⬇️
binr/radare2/radare2.c	49.88% <0%> (-0.06%)	⬇️
libr/core/linux_heap_glibc.c	15.9% <0%> (-0.04%)	⬇️
libr/asm/arch/v850/v850_disas.h	0% <0%> (ø)	⬆️
libr/asm/p/asm_lanai_gnu.c	0% <0%> (ø)	⬆️
libr/magic/magic.c	34.3% <0%> (ø)	⬆️
libr/core/panels.c	0% <0%> (ø)	⬆️
libr/anal/p/anal_v850.c	0% <0%> (ø)	⬆️
libr/core/cmd_debug.c	20.66% <0%> (+0.24%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a75230...26db2c0. Read the comment docs.

[radare]

uhm, doesnt looks good here

[radare]

without curvy

[radare]

before was not looking great either..

[jdz]

What font is this?

It looks like it does not have the "box drawing" Unicode block (the lines are way lighter than the font itself). It seems to me that the missing corner and vertical line characters are pulled from one font, and this font does not have dashed vertical line, so it is pulled from yet another font.

In #11727 I included screenshots with 4 different monospace fonts that do have characters for the whole "box drawing" Unicode block. You might have noticed that I've removed some of the screenshots from the original comment. That's because I later found out that in the other screenshots the box drawing characters were taken from DejaVu Sans Mono.

To summarise: not all fonts have the box drawing characters in the font, but when they do, there's a great chance the whole Unicode block is included. If your favourite font does not have this unicode block then the font substitution must be configured. There's ample information on how to do it on Linux with fontconfig; not sure about MacOS.

I still stand by this change and think it's the right thing to do.

[radare]

On 9 Oct 2018, at 09:59, Jānis Džeriņš ***@***.***> wrote: What font is this?

Agave

It looks like it does not have the "box drawing" Unicode block (the lines are way lighter than the font itself). It seems to me that the missing corner and vertical line characters are pulled from one font, and this font does not have dashed vertical line, so it is pulled from yet another font.

Yeah may be the reason. which font do you use?

…

In #11727 <#11727> I included screenshots with 4 different monospace fonts that do have characters for the whole "box drawing" Unicode block. You might have noticed that I've removed some of the screenshots from the original comment. That's because I later found out that in the other screenshots the box drawing characters were taken from DejaVu Sans Mono. To summarise: not all fonts have the box drawing characters in the font, but when they do, there's a great chance the whole Unicode block is included. If your favourite font does not have this unicode block then the font substitution must be configured. There's ample information on how to do it on Linux with fontconfig; not sure about MacOS. I still stand by this change and think it's the right thing to do. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#11770 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3-lu_GBU7ioeH2_q9i-2WgdGs9r1Ryks5ujFdQgaJpZM4XMthX>.

[jdz]

I use Input: http://input.fontbureau.com/.

[XVilka]

Maybe open a bug in fonts missing those characters?

…

On Fri, Oct 12, 2018, 8:39 PM Jānis Džeriņš ***@***.***> wrote: I use Input: http://input.fontbureau.com/. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#11770 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMZ_YSajsAEh9vuOVjDjdMFi8LB_wFOks5ukI2ZgaJpZM4XMthX> .

[radare]

Font makers are strange copyright creatures. Not sure if we can make it change

…

On 13 Oct 2018, at 04:05, Anton Kochkov ***@***.***> wrote: Maybe open a bug in fonts missing those characters? On Fri, Oct 12, 2018, 8:39 PM Jānis Džeriņš ***@***.***> wrote: > I use Input: http://input.fontbureau.com/. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#11770 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAMZ_YSajsAEh9vuOVjDjdMFi8LB_wFOks5ukI2ZgaJpZM4XMthX> > . > — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.