Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13000 #13083

Merged
merged 1 commit into from Mar 19, 2019
Merged

Fix #13000 #13083

merged 1 commit into from Mar 19, 2019

Conversation

XVilka
Copy link
Contributor

@XVilka XVilka commented Feb 13, 2019

I don't like the whole type renaming code, but that will require more changes, so let's do it later.

@XVilka XVilka added this to the 3.3.0 milestone Feb 13, 2019
@radare
Copy link
Collaborator

radare commented Feb 13, 2019

please rebase

@XVilka
Copy link
Contributor Author

XVilka commented Feb 14, 2019

Will push tests fixes tonight.

@XVilka XVilka force-pushed the int32_t branch 2 times, most recently from ca4f510 to f8eb209 Compare February 15, 2019 05:16
@radare
Copy link
Collaborator

radare commented Feb 16, 2019

not sure if this is right..technically rax/rdx.. are 64bit , is the use of those bounded to 32 or its wrong?

screenshot 2019-02-16 at 03 16 42

@XVilka
Copy link
Contributor Author

XVilka commented Feb 16, 2019

@radare it is unrelated, separate bug. Good catch! Keep in mind that int is int32_t on most platforms, thus the initial detection was wrong.

@ret2libc
Copy link
Contributor

@XVilka what's the status of this? Is this WIP or ready to be reviewed+merged?

@XVilka
Copy link
Contributor Author

XVilka commented Feb 25, 2019

@ret2libc it is ready and very simple anyway, just need to send a PR fixing tests, sorry hadn't time to do that. If you have a spare minute you can do it and merge.

@radare
Copy link
Collaborator

radare commented Mar 8, 2019

please rebase

@radare
Copy link
Collaborator

radare commented Mar 18, 2019

(DUP) pls rebase

@XVilka XVilka force-pushed the int32_t branch 2 times, most recently from 6e7356a to de179ce Compare March 18, 2019 12:39
@codecov-io
Copy link

Codecov Report

Merging #13083 into master will increase coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13083      +/-   ##
==========================================
+ Coverage   36.87%   36.88%   +<.01%     
==========================================
  Files         933      933              
  Lines      299395   299399       +4     
==========================================
+ Hits       110416   110419       +3     
- Misses     188979   188980       +1
Impacted Files Coverage Δ
libr/anal/var.c 80.34% <100%> (ø) ⬆️
libr/core/anal_tp.c 94.12% <80%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3568f0...4a340cd. Read the comment docs.

@XVilka XVilka merged commit 652df0b into radareorg:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants