New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #13000 #13083
Fix #13000 #13083
Conversation
please rebase |
Will push tests fixes tonight. |
ca4f510
to
f8eb209
Compare
@radare it is unrelated, separate bug. Good catch! Keep in mind that |
@XVilka what's the status of this? Is this WIP or ready to be reviewed+merged? |
@ret2libc it is ready and very simple anyway, just need to send a PR fixing tests, sorry hadn't time to do that. If you have a spare minute you can do it and merge. |
please rebase |
(DUP) pls rebase |
6e7356a
to
de179ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #13083 +/- ##
==========================================
+ Coverage 36.87% 36.88% +<.01%
==========================================
Files 933 933
Lines 299395 299399 +4
==========================================
+ Hits 110416 110419 +3
- Misses 188979 188980 +1
Continue to review full report at Codecov.
|
I don't like the whole type renaming code, but that will require more changes, so let's do it later.