New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dinamically find radare2 install dir on Windows #14323
Conversation
@@ -1143,7 +1143,21 @@ R_API bool r_sys_tts(const char *txt, bool bg) { | |||
R_API const char *r_sys_prefix(const char *pfx) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably return char * in the heap here. this static char *thing will fail if we use more than one rsysprefix in the same function or so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe do this change in a separate PR. also i dontn like this separation of windows and cutter, i dont see why cutter windows build should be different than the standard windows build
cutter doesn't ship a radare2.exe, so if someone installs just cutter this would fail. Also I think there is one more thing wrong with this. I just noticed that my install dir has a different structure from the one in appveyor, The exes are inside a bin folder on my system. Is this because of the --shared flag? |
Codecov Report
@@ Coverage Diff @@
## master #14323 +/- ##
==========================================
- Coverage 37.85% 37.84% -0.01%
==========================================
Files 948 948
Lines 305785 305802 +17
==========================================
- Hits 115741 115739 -2
- Misses 190044 190063 +19
Continue to review full report at Codecov.
|
I will check the broken tests |
OK, It's working now, but Appveyor is broken on master. Also because of 977e8ef, I think the build script for Cutter and the Windows installer will have to add |
@radare no, it isn't even merged on master, and it is master that's broken. I have no idea why. I cannot reproduce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
#10613
better #14315
Fixes types and etc not being loaded if radare2 is spawned outside of install dir