Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cmd_depth task-local #14888

Merged
merged 1 commit into from Aug 24, 2019
Merged

Make cmd_depth task-local #14888

merged 1 commit into from Aug 24, 2019

Conversation

thestr4ng3r
Copy link
Contributor

Racy otherwise (depths from different tasks will "add up")

@codecov-io
Copy link

Codecov Report

Merging #14888 into master will decrease coverage by <.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14888      +/-   ##
==========================================
- Coverage   38.32%   38.32%   -0.01%     
==========================================
  Files         960      960              
  Lines      314069   314070       +1     
==========================================
- Hits       120376   120375       -1     
- Misses     193693   193695       +2
Impacted Files Coverage Δ
libr/core/cconfig.c 88.79% <100%> (ø) ⬆️
libr/core/core.c 44.56% <100%> (-0.03%) ⬇️
libr/core/task.c 56.97% <100%> (+0.12%) ⬆️
libr/cons/cons.c 52.88% <100%> (+0.05%) ⬆️
libr/core/cmd.c 45.99% <80%> (ø) ⬆️
libr/core/project.c 57.47% <0%> (-0.34%) ⬇️
libr/core/visual.c 13.11% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61c7fe8...d994fcd. Read the comment docs.

@radare radare merged commit f5c5d0a into master Aug 24, 2019
@thestr4ng3r thestr4ng3r deleted the cmd-depth-task branch August 24, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants