Infer fixes - round 2 #4993
Merged
Infer fixes - round 2 #4993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please squash |
|
if you fix stuff in sdb do it in the original repo , not here |
|
Ok... shall I unstage all shlr commits in that case? |
|
only sdb and capstone, the other ones are not living outside |
| @@ -153,9 +153,12 @@ R_API ut8 *r_crypto_get_output(RCrypto *cry, int *size) { | |||
| memcpy (buf, cry->output, *size); | |||
| } else { | |||
| /* initialize */ | |||
| const int size = 4096; | |||
| cry->output = realloc(buf, size); | |||
There was a problem hiding this comment.
if realloc fails it will leak buf
|
fully reviewed. please address those comments and i'll merge |
| @@ -167,8 +167,8 @@ static int r_debug_bf_kill(RDebug *dbg, int pid, int tid, int sig) { | |||
| static RList *r_debug_native_map_get(RDebug *dbg) { | |||
| RIOBdescbg *o = dbg->iob.io->desc->data; | |||
| BfvmCPU *c = o->bfvm; | |||
| RList *list = r_list_new (); | |||
| list->free = (RListFree)r_debug_map_free; | |||
There was a problem hiding this comment.
r_debug_map_free is better than just plain free
R_API void r_debug_map_free(RDebugMap *map) {
free (map->name);
free (map);
}
|
ping |
Squashed: Fix PR issues Squashed: More PR Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits bring the infer result to
The memory leaks are down to things being added to a list, causing false positives.
I haven't fully worked through shlr and some other files where I wasn't entirely sure how to handle the errors.