fixing aek- #5454
Merged
fixing aek- #5454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added a test here https://github.com/radare/radare2-regressions/pull/498 |
| @@ -2,7 +2,11 @@ | |||
|
|
|||
| #include "r_util.h" | |||
| #include "r_core.h" | |||
|
|
|||
| static int sdb_del (void *p, const char *k, const char *v) { | |||
| struct r_anal_esil_t *esil = (struct r_anal_esil_t *)p; | |||
There was a problem hiding this comment.
Use the typedefed name RAnalEsil
oddcoder
force-pushed
the
fix_aek_delete
branch
from
9d1bdc2
to
68cb946
Compare
|
test suite is behaving strangely segfault on Clang on linux, and passed gcc linux and mac clang |
|
Try with asan
|
I didn't touch |
oddcoder
force-pushed
the
fix_aek_delete
branch
from
68cb946
to
8952d16
Compare
|
well now it builds and I didn't do anything extra @radare I will open seprate issue for the random segmentation fault because it doesn't have anything to do with my pr |
oddcoder
force-pushed
the
fix_aek_delete
branch
from
8952d16
to
4881881
Compare
according to `ae?`, aek- is used to delete all esil->stats key/value pairs, but it wasn't actually implemented.
oddcoder
force-pushed
the
fix_aek_delete
branch
from
4881881
to
24d2b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to
ae?,aek-is used to delete all esil->stats key/value pairs, but it wasn't actually implemented.this is its implementation