Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying new appveyor configuration #7474

Merged
merged 1 commit into from May 18, 2017
Merged

Trying new appveyor configuration #7474

merged 1 commit into from May 18, 2017

Conversation

xarkes
Copy link
Contributor

@xarkes xarkes commented May 11, 2017

No description provided.

@XVilka
Copy link
Contributor

XVilka commented May 16, 2017

@xarkes why do you build against capstone release?

@xarkes
Copy link
Contributor Author

xarkes commented May 16, 2017

It's a fail because I did some other build then I commited with -a. Will fix it thx

@xarkes
Copy link
Contributor Author

xarkes commented May 16, 2017

Ok so with this configuration mingw32 and msvc (with meson) works great. You can download the artifacts from appveyor.

sys/cccl Outdated
val=$(echo "$1" | cut -c2-)
clopt="${clopt},${slash}${val}"
# All '/' options are assumed to be absolute path, not options
path=$(cygpath -aw "$1")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is a portable option... E.g. pure mingw installation wont have this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK for now, just may be nice to keep that in mind.

Added msvc_meson build configuration
Added downloadable artifacts
@XVilka
Copy link
Contributor

XVilka commented May 18, 2017

LGTM

@radare
Copy link
Collaborator

radare commented May 18, 2017

its green\o/

@radare
Copy link
Collaborator

radare commented May 18, 2017

ok to merge?

@xarkes
Copy link
Contributor Author

xarkes commented May 18, 2017

Why not ? :)

@radare radare merged commit ccc39a8 into radareorg:master May 18, 2017
@xarkes xarkes deleted the appveyor branch May 29, 2017 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants