Pdb parsing fixes + typos #7997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radare
reviewed
Jul 24, 2017
libr/bin/pdb/pdb.c
Outdated
| return 0; | ||
| } | ||
| if (num_streams<0 || tmp_data_max_size <= 0) { | ||
| R_FREE(data); | ||
| eprintf ("too much amount of streams\n" | ||
| "curremt pdb file is not correct\n"); | ||
| eprintf ("Too many streams: " |
There was a problem hiding this comment.
i think this fits in 1 line :P
radare
reviewed
Jul 24, 2017
libr/bin/pdb/pdb.c
Outdated
| @@ -136,21 +136,21 @@ static int init_pdb7_root_stream(R_PDB *pdb, int *root_page_list, int pages_amou | |||
| data_end = data + tmp_data_max_size; | |||
| if (tmp_data_max_size> data_size) { | |||
| R_FREE(data); | |||
| eprintf ("invalid max tmp data size\n"); | |||
| eprintf ("Invalid max tmp data size.\n"); | |||
| return 0; | |||
| } | |||
| if (num_streams<0 || tmp_data_max_size <= 0) { | |||
There was a problem hiding this comment.
missing spaces around <, maybe throw an r2-indent here?
radare
reviewed
Jul 24, 2017
libr/bin/pdb/pdb.c
Outdated
| @@ -176,37 +176,41 @@ static int init_pdb7_root_stream(R_PDB *pdb, int *root_page_list, int pages_amou | |||
| if ((pos + num_pages) > tmp_data_max_size) { | |||
| R_FREE(data); | |||
| R_FREE(sizes); | |||
| eprintf("warning: looks like there is not correct values " | |||
| "of stream size in pdb file\n"); | |||
| eprintf ("Warning: looks like there is no correct values " | |||
radare
reviewed
Jul 24, 2017
libr/bin/pdb/pdb.c
Outdated
| memset(tmp, 0, num_pages * 4); | ||
| ut32 size = num_pages * 4; | ||
| tmp = (char *) malloc (size); | ||
| memset(tmp, 0, size); |
There was a problem hiding this comment.
check for null ptr and use calloc to avoid the memset
There was a problem hiding this comment.
also missing space before (
|
lgtm |
|
|
|
Yes ? |
|
fix the conflict |
|
ah yy ofc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #6434
Here is (part of) the output now: