Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorize the pf output (especially in r2 -nn binary case) #16193

Open
XVilka opened this issue Mar 12, 2020 · 1 comment
Open

Colorize the pf output (especially in r2 -nn binary case) #16193

XVilka opened this issue Mar 12, 2020 · 1 comment
Labels
enhancement good first issue hackaton pf Print format, `pf` command visual Visual console mode (NOT PANELS!)

Comments

@XVilka
Copy link
Contributor

XVilka commented Mar 12, 2020

Is your feature request related to a problem? Please describe.
Currently radare2 prints both pf and built-in pf output in r2 -nn mode without any colors, even if they are enabled. It would be amazing to improve the readability to colorize them according to the current color options and colorscheme.

image

@XVilka XVilka added enhancement good first issue pf Print format, `pf` command visual Visual console mode (NOT PANELS!) labels Mar 12, 2020
@XVilka XVilka added this to To do in Console Interface Improvements via automation Mar 12, 2020
@XVilka XVilka added this to To do in User Experience via automation Mar 12, 2020
@radare
Copy link
Collaborator

radare commented Mar 15, 2020

also i as thinking in having ad integrated into pf.. so we can tell pf to magically guess the type stored in one place by telescoping it and making some assumptions to see if the dword matches an allocated address, or printable chars to represent a string.

also what i find out is that ad is not detecting the strings when the first byte is nul.. basically "" strings in disassembly never appear.

@XVilka XVilka added the hackaton label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue hackaton pf Print format, `pf` command visual Visual console mode (NOT PANELS!)
Development

No branches or pull requests

2 participants