Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwriting projects #18641

Closed
trufae opened this issue Apr 28, 2021 · 4 comments
Closed

Overwriting projects #18641

trufae opened this issue Apr 28, 2021 · 4 comments
Assignees
Milestone

Comments

@trufae
Copy link
Collaborator

trufae commented Apr 28, 2021

Imagine the following scenario:

$ r2 /bin/ls
> Ps jeje
> q

And then:

$ r2 /bin/sleep
> Ps jeje
> q

Issues found:

  • Nothing blocks the user to overwrite an existing project
  • Projects should be only saved if they were loaded first or they dont exist
  • Quitting asks the user to save the project again
  • We may delete projects before overwriting them imho
@trufae trufae added this to the 5.3.0 milestone Apr 28, 2021
@Shadorain
Copy link
Contributor

This is the same with layouts but is not as much of a big deal.

@trufae
Copy link
Collaborator Author

trufae commented Apr 29, 2021

Both issues should be easy to fix. Do you want to give it a try? Otherwise i will fix them as soon as i get some spare time

@Shadorain
Copy link
Contributor

Both issues should be easy to fix. Do you want to give it a try? Otherwise i will fix them as soon as i get some spare time

For sure if u could point me in the right direction, I'll grep through and see where it'd be in the project tho unless u have a specific place.

@trufae trufae self-assigned this May 11, 2021
@trufae
Copy link
Collaborator Author

trufae commented May 25, 2021

Everything you need to touch is in project.c. Just use the commands above and make it behave as described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants