Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build will fail if the path to radare2 repo contains '.c' #21287

Closed
lveyde opened this issue Jan 23, 2023 · 4 comments
Closed

The build will fail if the path to radare2 repo contains '.c' #21287

lveyde opened this issue Jan 23, 2023 · 4 comments

Comments

@lveyde
Copy link

lveyde commented Jan 23, 2023

Environment

Linux x86_64 (RHEL 8.7)

Description

It seems that if the path to radare2 repo contains '.c' then the build through sys/install.sh script will fail, as well as some manual build attempt with make, as it gets replaced with '.o'.

The build will finish with errors:
gmake[1]: *** [Makefile:26: all] Error 2
gmake: *** [Makefile:56: all] Error 2

and searching though the messages will give something like:
gmake[4]: *** No rule to make target '/tmp/test.oat/radare2/libr/../shlr/qjs/src/quickjs.o'. Stop.

Please note that the actual directory name where the radare2 repo was located in this case was /tmp/test.cat/radare2/

Test

./sys/install.sh

@trufae
Copy link
Collaborator

trufae commented Jan 23, 2023

If your path have spaces or dots its better to use meson

@lveyde
Copy link
Author

lveyde commented Jan 23, 2023

If your path have spaces or dots its better to use meson

If it's a known issue then may be it worth to add it to the instructions, or at least add a note not to clone the repo into any directory with . (dot) in it's name.

BTW from my testing it seems that the issue was specifically with .c as having for example .d in the path was OK.
Of course I haven't tested all .[a-zA-Z] combinations.

@trufae
Copy link
Collaborator

trufae commented Feb 9, 2023

Well this should be fixable. we have a ci job to test such things, but not for .c. just low prio for me because it makes no sense for me to have dots or spaces in directories. ill keep this open and address it when i get some spare time

@trufae trufae closed this as completed in 35c591c Feb 20, 2023
@trufae
Copy link
Collaborator

trufae commented Feb 20, 2023

Had few mins to check this issue and pushed a fix now. thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants